mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Hindman" <b...@berkeley.edu>
Subject Re: Review Request 28319: Add enable-libevent flag to Libprocess.
Date Thu, 04 Dec 2014 18:28:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28319/#review63871
-----------------------------------------------------------

Ship it!



3rdparty/libprocess/Makefile.am
<https://reviews.apache.org/r/28319/#comment106186>

    Wierd alignment of slashes?



3rdparty/libprocess/configure.ac
<https://reviews.apache.org/r/28319/#comment106188>

    Indent +2 please.



3rdparty/libprocess/configure.ac
<https://reviews.apache.org/r/28319/#comment106189>

    Can we elaborate just a little bit here please? See the other examples, something like:
    
    You have requested to use libevent but no suitable libevent could be found.


- Benjamin Hindman


On Dec. 3, 2014, 9:49 p.m., Joris Van Remoortere wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28319/
> -----------------------------------------------------------
> 
> (Updated Dec. 3, 2014, 9:49 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Niklas Nielsen.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> This flag will be used to distinguish between libev (default) and libevent.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/Makefile.am aebd281da41325a0246f5c57780928afc22a1baa 
>   3rdparty/libprocess/configure.ac 314c8b842d07e1344659449866f7e85c48854204 
>   3rdparty/libprocess/src/process.cpp 89e0e0cc15ab3fc8b1156906ef5f9b314c72c7e3 
> 
> Diff: https://reviews.apache.org/r/28319/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message