mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Niklas Nielsen" <...@qni.dk>
Subject Re: Review Request 28069: Propagated slave shutdown grace period to Executor and CommandExecutor.
Date Wed, 03 Dec 2014 22:03:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28069/#review63751
-----------------------------------------------------------

Ship it!


Almost there. Also, see my comment on moving the code block in the previous review.


src/launcher/executor.cpp
<https://reviews.apache.org/r/28069/#comment106049>

    You have a log line above for the resulting shutdown timeout. How about having it here
as well?



src/slave/containerizer/containerizer.cpp
<https://reviews.apache.org/r/28069/#comment106047>

    only 2 space indent on wrapping around '='
    
    See 'Continuation' in http://mesos.apache.org/documentation/latest/mesos-c++-style-guide/



src/slave/containerizer/containerizer.cpp
<https://reviews.apache.org/r/28069/#comment106048>

    same here


- Niklas Nielsen


On Nov. 24, 2014, 9:19 a.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28069/
> -----------------------------------------------------------
> 
> (Updated Nov. 24, 2014, 9:19 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Niklas Nielsen, and Till Toenshoff.
> 
> 
> Bugs: MESOS-1571
>     https://issues.apache.org/jira/browse/MESOS-1571
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> The configurable slave's executor_shutdown_grace_period flag is propagated to Executor
and CommandExecutor via CommandInfo and an environment variable. Shutdown timeout in ExecutorProcess
and signal escalation timeout in CommandExecutor are now dependent on this value.
> 
> 
> Diffs
> -----
> 
>   src/exec/exec.cpp e15f834 
>   src/launcher/executor.cpp 6175bf5 
>   src/slave/constants.hpp fd1c1ab 
>   src/slave/constants.cpp 2a99b11 
>   src/slave/containerizer/containerizer.cpp 1448bea 
>   src/slave/flags.hpp 4f5b8b4 
>   src/slave/slave.cpp ed63ded 
>   src/tests/gc_tests.cpp cb5dc5f 
>   src/tests/slave_tests.cpp 3b80ca9 
> 
> Diff: https://reviews.apache.org/r/28069/diff/
> 
> 
> Testing
> -------
> 
> make check (Mac OS 10.9.4, Ubuntu 14.04)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message