mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joris Van Remoortere" <joris.van.remoort...@gmail.com>
Subject Re: Review Request 28321: Introduce libevent header and implementation.
Date Wed, 03 Dec 2014 19:49:09 GMT


> On Dec. 2, 2014, 10:13 p.m., Benjamin Hindman wrote:
> > 3rdparty/libprocess/src/libevent.cpp, line 39
> > <https://reviews.apache.org/r/28321/diff/3/?file=779192#file779192line39>
> >
> >     Can we get out better error messages here? Maybe a TODO?

There is currently no way to get a return code here. From the implementation it seems the
only way this can fail is if we can't allocate memory for the structure or the default configuration
is somehow invalid.


- Joris


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28321/#review63591
-----------------------------------------------------------


On Dec. 3, 2014, 7:45 p.m., Joris Van Remoortere wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28321/
> -----------------------------------------------------------
> 
> (Updated Dec. 3, 2014, 7:45 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Niklas Nielsen.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/Makefile.am aebd281da41325a0246f5c57780928afc22a1baa 
>   3rdparty/libprocess/src/libevent.hpp PRE-CREATION 
>   3rdparty/libprocess/src/libevent.cpp PRE-CREATION 
>   3rdparty/libprocess/src/process.cpp 89e0e0cc15ab3fc8b1156906ef5f9b314c72c7e3 
> 
> Diff: https://reviews.apache.org/r/28321/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message