mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Evelina Dumitrescu" <evelina.a.dumitre...@gmail.com>
Subject Re: Review Request 28543: stout: Replaced obsolete functions gethostbyname2_r and gethostbyname2 with getaddrinfo and introduced getIP
Date Tue, 02 Dec 2014 22:18:53 GMT


> On Dec. 2, 2014, 6 p.m., Dominic Hamon wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp, line 868
> > <https://reviews.apache.org/r/28543/diff/2/?file=779878#file779878line868>
> >
> >     why isn't this calling getIP() ?

Here it returns the ai_cannonname, not the ai_addr field.


- Evelina


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28543/#review63553
-----------------------------------------------------------


On Dec. 2, 2014, 2:07 a.m., Evelina Dumitrescu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28543/
> -----------------------------------------------------------
> 
> (Updated Dec. 2, 2014, 2:07 a.m.)
> 
> 
> Review request for mesos, Dominic Hamon and Joris Van Remoortere.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> gethostbyname2_r and gethostbyname2 are obsolete functions and should be replaced.
> geIP retrieves a IP address from a given hostname.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp a992bd9f7caf3abcc2c5e14519ca7e3ac045bb4b

>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp ec259cdee876c64f3e562aa77d4d52e964a173ab

> 
> Diff: https://reviews.apache.org/r/28543/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Evelina Dumitrescu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message