mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mesos ReviewBot" <...@mesos.apache.org>
Subject Re: Review Request 20423: Moved validation visitors out of master.cpp.
Date Tue, 02 Dec 2014 21:24:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20423/#review63579
-----------------------------------------------------------


Patch looks great!

Reviews applied: [20423]

All tests passed.

- Mesos ReviewBot


On Dec. 2, 2014, 8:36 p.m., Dominic Hamon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20423/
> -----------------------------------------------------------
> 
> (Updated Dec. 2, 2014, 8:36 p.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Bugs: MESOS-1064
>     https://issues.apache.org/jira/browse/MESOS-1064
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> This is the first step toward being able to write independent unit tests for the validation
visitors.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 86161fe7a8bdd86958d24adb74d434cd92d7dfb8 
>   src/master/master.cpp 8fcda4b9b5857f14cff8f6af2de31cca0208b88d 
>   src/master/offer_checker.hpp PRE-CREATION 
>   src/master/offer_checker.cpp PRE-CREATION 
>   src/master/task_checker.hpp PRE-CREATION 
>   src/master/task_checker.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/20423/diff/
> 
> 
> Testing
> -------
> 
> make check.
> ran Java test framework.
> 
> 
> Thanks,
> 
> Dominic Hamon
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message