mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jie Yu" <yujie....@gmail.com>
Subject Re: Review Request 20423: Moved validation visitors out of master.cpp.
Date Tue, 02 Dec 2014 18:07:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20423/#review63552
-----------------------------------------------------------



3rdparty/libprocess/include/process/timeout.hpp
<https://reviews.apache.org/r/20423/#comment105817>

    Could you please split the patches? Is this just a cleanup, or it's necessary for this
patch?



src/Makefile.am
<https://reviews.apache.org/r/20423/#comment105824>

    visitor is the pattern we use to check offers and tasks. How about calling them task_checker.hpp
and offer_checker.hpp?



src/master/offervisitor.hpp
<https://reviews.apache.org/r/20423/#comment105828>

    We rarely use typedef as it's not good for readability. Could you revert?



src/master/taskinfovisitor.hpp
<https://reviews.apache.org/r/20423/#comment105829>

    Ditto.



src/slave/containerizer/mesos/containerizer.cpp
<https://reviews.apache.org/r/20423/#comment105830>

    Hum, looks like you need to rebase.


- Jie Yu


On Oct. 23, 2014, 10:48 p.m., Dominic Hamon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20423/
> -----------------------------------------------------------
> 
> (Updated Oct. 23, 2014, 10:48 p.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Bugs: MESOS-1064
>     https://issues.apache.org/jira/browse/MESOS-1064
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> This is the first step toward being able to write independent unit tests for the validation
visitors.
> 
> It also uses Owned to make visitor cleanup simpler (non-existent).
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/timeout.hpp 0bf63e11a7a63b714aafb5386bf2d169260396ce

>   src/Makefile.am 2617f77b757cb7414889520c88b1bc203dedef09 
>   src/master/master.cpp 95589b8f25a3e496eabc0cf84319c883c1ed7aec 
>   src/master/offervisitor.hpp PRE-CREATION 
>   src/master/offervisitor.cpp PRE-CREATION 
>   src/master/taskinfovisitor.hpp PRE-CREATION 
>   src/master/taskinfovisitor.cpp PRE-CREATION 
>   src/slave/containerizer/mesos/containerizer.cpp 9f745d897119a814bd9f8e1b6a0ce5eaef60ed36

>   src/zookeeper/group.hpp 924613065521a72887a2721b3db89f448fa50900 
> 
> Diff: https://reviews.apache.org/r/20423/diff/
> 
> 
> Testing
> -------
> 
> make check.
> ran Java test framework.
> 
> 
> Thanks,
> 
> Dominic Hamon
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message