mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mesos ReviewBot" <...@mesos.apache.org>
Subject Re: Review Request 28514: Updated WhitelistWatcher behaviour and introduced initial whitelist.
Date Tue, 02 Dec 2014 11:54:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28514/#review63521
-----------------------------------------------------------


Patch looks great!

Reviews applied: [28514]

All tests passed.

- Mesos ReviewBot


On Dec. 2, 2014, 11:10 a.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28514/
> -----------------------------------------------------------
> 
> (Updated Dec. 2, 2014, 11:10 a.m.)
> 
> 
> Review request for mesos, Cody Maloney, Niklas Nielsen, and Vinod Kone.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> The subscriber may now provide an initial whitelist and will be notified only when the
parsed whitelist differs from the initial one. The subscriber is not explicitly notified that
there is no whitelist unless they have provided a valid initial whitelist before. This change
suppresses gmock warnings for uninteresting mock function calls.
> 
> 
> Diffs
> -----
> 
>   src/watcher/whitelist_watcher.hpp 5838854 
>   src/watcher/whitelist_watcher.cpp 32713bb 
> 
> Diff: https://reviews.apache.org/r/28514/diff/
> 
> 
> Testing
> -------
> 
> make check (Mac OS 10.9.4, Ubuntu 14.04)
> checked test log for gmock warnings.
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message