Return-Path: X-Original-To: apmail-mesos-dev-archive@www.apache.org Delivered-To: apmail-mesos-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 50E4C10405 for ; Mon, 24 Nov 2014 18:00:57 +0000 (UTC) Received: (qmail 82444 invoked by uid 500); 24 Nov 2014 18:00:57 -0000 Delivered-To: apmail-mesos-dev-archive@mesos.apache.org Received: (qmail 82375 invoked by uid 500); 24 Nov 2014 18:00:57 -0000 Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list dev@mesos.apache.org Received: (qmail 82356 invoked by uid 99); 24 Nov 2014 18:00:56 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 24 Nov 2014 18:00:56 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id A299D67CD5; Mon, 24 Nov 2014 18:00:55 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3306686464164977374==" MIME-Version: 1.0 Subject: Re: Review Request 28069: Propagated slave shutdown grace period to Executor and CommandExecutor. From: "Mesos ReviewBot" To: "Niklas Nielsen" , "Till Toenshoff" , "Ben Mahler" Cc: "Mesos ReviewBot" , "mesos" , "Alexander Rukletsov" Date: Mon, 24 Nov 2014 18:00:55 -0000 Message-ID: <20141124180055.15978.18135@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Mesos ReviewBot" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/28069/ X-Sender: "Mesos ReviewBot" References: <20141124171926.15977.32113@reviews.apache.org> In-Reply-To: <20141124171926.15977.32113@reviews.apache.org> Reply-To: "Mesos ReviewBot" X-ReviewRequest-Repository: mesos-git --===============3306686464164977374== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28069/#review62814 ----------------------------------------------------------- Patch looks great! Reviews applied: [28065, 28063, 28069] All tests passed. - Mesos ReviewBot On Nov. 24, 2014, 5:19 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28069/ > ----------------------------------------------------------- > > (Updated Nov. 24, 2014, 5:19 p.m.) > > > Review request for mesos, Ben Mahler, Niklas Nielsen, and Till Toenshoff. > > > Bugs: MESOS-1571 > https://issues.apache.org/jira/browse/MESOS-1571 > > > Repository: mesos-git > > > Description > ------- > > The configurable slave's executor_shutdown_grace_period flag is propagated to Executor and CommandExecutor via CommandInfo and an environment variable. Shutdown timeout in ExecutorProcess and signal escalation timeout in CommandExecutor are now dependent on this value. > > > Diffs > ----- > > src/exec/exec.cpp e15f834 > src/launcher/executor.cpp 6175bf5 > src/slave/constants.hpp fd1c1ab > src/slave/constants.cpp 2a99b11 > src/slave/containerizer/containerizer.cpp 1448bea > src/slave/flags.hpp 4f5b8b4 > src/slave/slave.cpp ed63ded > src/tests/gc_tests.cpp cb5dc5f > src/tests/slave_tests.cpp 3b80ca9 > > Diff: https://reviews.apache.org/r/28069/diff/ > > > Testing > ------- > > make check (Mac OS 10.9.4, Ubuntu 14.04) > > > Thanks, > > Alexander Rukletsov > > --===============3306686464164977374==--