Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@mesos.apache.org
Content-Type: multipart/alternative;
 boundary="===============4229036441791512407=="
MIME-Version: 1.0
Subject: Re: Review Request 28253: Add query string joiner
From: "Cody Maloney" <cody@mesosphere.io>
To: "Cody Maloney" <cody@mesosphere.io>,
 "Ben Mahler" <benjamin.mahler@gmail.com>, "mesos" <dev@mesos.apache.org>
Date: Thu, 20 Nov 2014 00:50:18 -0000
Message-ID: <20141120005018.15325.93860@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Cody Maloney" <noreply@reviews.apache.org>
References: <20141120004122.16171.39012@reviews.apache.org>
In-Reply-To: <20141120004122.16171.39012@reviews.apache.org>
Reply-To: "Cody Maloney" <cody@mesosphere.io>

--===============4229036441791512407==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


> On Nov. 20, 2014, 12:41 a.m., Ben Mahler wrote:
> > 3rdparty/libprocess/include/process/http.hpp, lines 415-416
> > <https://reviews.apache.org/r/28253/diff/1/?file=770208#file770208line415>
> >
> >     Could you show the context on why you need this? Seems like an unfortuante API, because it's exposing encoding of a subsection of a request. Is this implying that encoding of request queries needs to be done in multiple places?
> >     
> >     In general, please write descriptions on your reviews! Helps provide context for the reviewers :)

Doesn't need to be done in multiple places, but at the time of just this commit all the methods of sending requests across the network require passing them a constructed/encoded query string.

In the following review (https://reviews.apache.org/r/28254/) I add a way to send more generalized responses.


- Cody


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28253/#review62303
-----------------------------------------------------------


On Nov. 20, 2014, 12:50 a.m., Cody Maloney wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28253/
> -----------------------------------------------------------
> 
> (Updated Nov. 20, 2014, 12:50 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-2132
>     https://issues.apache.org/jira/browse/MESOS-2132
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> This is needed to turn Request objects into http request which we send across the wire. The existing HTTP request sending code expects the query string to be already constructed.
> 
> Ideally people can either just forward the query string they get to send it back across the wire or they can manipulate it using the native C++ datatype (A hashmap), and then have it automatically re-encoded.
> 
> The parsing logic to go from a string to a map is already exists in this header, this just adds the other direction.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/http.hpp 9cf05acbb724ab9af8010d1788621d37a0e48e86 
>   3rdparty/libprocess/src/http.cpp b00f33339366f5c06b6f20e38c5ae0c23b8a9358 
>   3rdparty/libprocess/src/tests/http_tests.cpp a90e65f77904da0a45e1cc0cc9889ae69354a1a5 
> 
> Diff: https://reviews.apache.org/r/28253/diff/
> 
> 
> Testing
> -------
> 
> make distcheck ubuntu 14.04
> 
> 
> Thanks,
> 
> Cody Maloney
> 
>


--===============4229036441791512407==--