Return-Path: X-Original-To: apmail-mesos-dev-archive@www.apache.org Delivered-To: apmail-mesos-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7AA1710AAE for ; Sat, 15 Nov 2014 05:11:51 +0000 (UTC) Received: (qmail 22908 invoked by uid 500); 15 Nov 2014 05:11:51 -0000 Delivered-To: apmail-mesos-dev-archive@mesos.apache.org Received: (qmail 22842 invoked by uid 500); 15 Nov 2014 05:11:51 -0000 Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list dev@mesos.apache.org Received: (qmail 22827 invoked by uid 99); 15 Nov 2014 05:11:50 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 15 Nov 2014 05:11:50 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 9E5B7116497; Sat, 15 Nov 2014 05:11:50 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2829684657336211381==" MIME-Version: 1.0 Subject: Re: Review Request 27966: Add bind(), listen(), and accept() to Socket interface. Use these in process.cpp. From: "Joris Van Remoortere" To: "Niklas Nielsen" , "Benjamin Hindman" Cc: "Joris Van Remoortere" , "mesos" Date: Sat, 15 Nov 2014 05:11:50 -0000 Message-ID: <20141115051150.1251.6106@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Joris Van Remoortere" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/27966/ X-Sender: "Joris Van Remoortere" References: <20141115005853.1251.22523@reviews.apache.org> In-Reply-To: <20141115005853.1251.22523@reviews.apache.org> Reply-To: "Joris Van Remoortere" X-ReviewRequest-Repository: mesos-git --===============2829684657336211381== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Nov. 15, 2014, 12:58 a.m., Benjamin Hindman wrote: > > 3rdparty/libprocess/src/poll.cpp, line 121 > > > > > > Why don't we need to call process::initialize anymore? Put this back now that we moved the accept call down in the initializer. > On Nov. 15, 2014, 12:58 a.m., Benjamin Hindman wrote: > > 3rdparty/libprocess/src/process.cpp, lines 791-793 > > > > > > Why do you need to make the copy explicitly? this was done because we were using onReady / onFailed. Since we use onAny we don't need to do this anymore. - Joris ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27966/#review61583 ----------------------------------------------------------- On Nov. 14, 2014, 10:52 p.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27966/ > ----------------------------------------------------------- > > (Updated Nov. 14, 2014, 10:52 p.m.) > > > Review request for mesos, Benjamin Hindman and Niklas Nielsen. > > > Bugs: MESOS-1330 > https://issues.apache.org/jira/browse/MESOS-1330 > > > Repository: mesos-git > > > Description > ------- > > See Summary. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/socket.hpp 66838814236fc064a2463399fb15f4a815879bf5 > 3rdparty/libprocess/src/libev.hpp PRE-CREATION > 3rdparty/libprocess/src/libev.cpp PRE-CREATION > 3rdparty/libprocess/src/poll.cpp PRE-CREATION > 3rdparty/libprocess/src/process.cpp a34b8702b01dec9c954552de0b923866d172c453 > > Diff: https://reviews.apache.org/r/27966/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Joris Van Remoortere > > --===============2829684657336211381==--