Return-Path: X-Original-To: apmail-mesos-dev-archive@www.apache.org Delivered-To: apmail-mesos-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D819017D48 for ; Mon, 10 Nov 2014 14:24:53 +0000 (UTC) Received: (qmail 68840 invoked by uid 500); 10 Nov 2014 14:24:53 -0000 Delivered-To: apmail-mesos-dev-archive@mesos.apache.org Received: (qmail 68774 invoked by uid 500); 10 Nov 2014 14:24:53 -0000 Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list dev@mesos.apache.org Received: (qmail 68757 invoked by uid 99); 10 Nov 2014 14:24:53 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 10 Nov 2014 14:24:53 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id A37FC1DFDB3; Mon, 10 Nov 2014 14:24:56 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0278333826951375785==" MIME-Version: 1.0 Subject: Re: Review Request 27494: Integrated CRAM-MD5 Test Authenticatee module into slave. From: "Till Toenshoff" To: "Vinod Kone" , "Adam B" Cc: "mesos" , "Kapil Arya" , "Till Toenshoff" Date: Mon, 10 Nov 2014 14:24:56 -0000 Message-ID: <20141110142456.19819.95025@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Till Toenshoff" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/27494/ X-Sender: "Till Toenshoff" References: <20141109231746.19819.78670@reviews.apache.org> In-Reply-To: <20141109231746.19819.78670@reviews.apache.org> Reply-To: "Till Toenshoff" X-ReviewRequest-Repository: mesos-git --===============0278333826951375785== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27494/ ----------------------------------------------------------- (Updated Nov. 10, 2014, 2:24 p.m.) Review request for mesos, Adam B and Vinod Kone. Changes ------- Now following non optional Credential parameter Authenticatee interface. Bugs: MESOS-2040 https://issues.apache.org/jira/browse/MESOS-2040 Repository: mesos-git Description ------- Also fixes messages.proto to use a raw bytestream instead of a string for AuthenticationStartMessage as non CRAM-MD5 authentication may transmit binary data. Note that the change of AuthenticationStartMessage does basically have no impact on C++ based proto code other than the prevention of a warning due to non-UTF8 characters being encoded. That does in fact occur when using non CRAM-MD5 based SASL authentication mechanisms. Note that this patch covers modularized slave authentication only. Framework authentication is currently covered by the default (built-in) implementation. There will be a subsequent patch for modularized framework authentication. Diffs (updated) ----- src/messages/messages.proto de0e2a2 src/sched/sched.cpp 8ca0526 src/scheduler/scheduler.cpp c74187c src/slave/constants.hpp 701dd89 src/slave/constants.cpp d6ad78c src/slave/flags.hpp efbd35d src/slave/slave.hpp 72bbec9 src/slave/slave.cpp 81e0c4b Diff: https://reviews.apache.org/r/27494/diff/ Testing ------- make check NOTE all three CRAM-MD5 authenticatee module related RRs need to get applied before running make check. Thanks, Till Toenshoff --===============0278333826951375785==--