Return-Path: X-Original-To: apmail-mesos-dev-archive@www.apache.org Delivered-To: apmail-mesos-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id F37C517DFE for ; Sat, 8 Nov 2014 00:50:04 +0000 (UTC) Received: (qmail 83661 invoked by uid 500); 8 Nov 2014 00:50:04 -0000 Delivered-To: apmail-mesos-dev-archive@mesos.apache.org Received: (qmail 83585 invoked by uid 500); 8 Nov 2014 00:50:04 -0000 Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list dev@mesos.apache.org Received: (qmail 83568 invoked by uid 99); 8 Nov 2014 00:50:04 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 08 Nov 2014 00:50:04 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id E6F831DFD27; Sat, 8 Nov 2014 00:50:07 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1042881128364746881==" MIME-Version: 1.0 Subject: Review Request 27760: Revised authenticator interface to allow for two fold implementations. From: "Till Toenshoff" To: "Niklas Nielsen" , "Vinod Kone" , "Adam B" , "Kapil Arya" Cc: "mesos" , "Till Toenshoff" Date: Sat, 08 Nov 2014 00:50:07 -0000 Message-ID: <20141108005007.10454.18004@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Till Toenshoff" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/27760/ X-Sender: "Till Toenshoff" Reply-To: "Till Toenshoff" X-ReviewRequest-Repository: mesos-git --===============1042881128364746881== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27760/ ----------------------------------------------------------- Review request for mesos, Adam B, Kapil Arya, Niklas Nielsen, and Vinod Kone. Bugs: MESOS-2050 https://issues.apache.org/jira/browse/MESOS-2050 Repository: mesos-git Description ------- The initial design and implementation of the authenticator module interface caused issues and was not optimal for heavy lifting setup of external dependencies. By introducing a two fold design, this has been decoupled from the authentication message processing. The new design also gets us back on track to the goal of makeing SASL a soft dependency of mesos. Diffs ----- src/authentication/authenticator.hpp 2f95db1 src/authentication/cram_md5/authenticator.hpp 601248d src/master/master.hpp 687f178 src/master/master.cpp a860496 src/tests/cram_md5_authentication_tests.cpp 74ea2ad Diff: https://reviews.apache.org/r/27760/diff/ Testing ------- make check Thanks, Till Toenshoff --===============1042881128364746881==--