Return-Path: X-Original-To: apmail-mesos-dev-archive@www.apache.org Delivered-To: apmail-mesos-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2D31C171FC for ; Thu, 6 Nov 2014 06:47:37 +0000 (UTC) Received: (qmail 81414 invoked by uid 500); 6 Nov 2014 06:47:37 -0000 Delivered-To: apmail-mesos-dev-archive@mesos.apache.org Received: (qmail 81352 invoked by uid 500); 6 Nov 2014 06:47:37 -0000 Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list dev@mesos.apache.org Received: (qmail 81335 invoked by uid 99); 6 Nov 2014 06:47:36 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 06 Nov 2014 06:47:36 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 0E84A1DFC27; Thu, 6 Nov 2014 06:47:40 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3091435055490799032==" MIME-Version: 1.0 Subject: Re: Review Request 27651: Updated CRAMMD5Authentication tests to additionally run against the test authenticatee module. From: "Adam B" To: "Vinod Kone" , "Adam B" Cc: "mesos" , "Till Toenshoff" Date: Thu, 06 Nov 2014 06:47:40 -0000 Message-ID: <20141106064740.10455.70123@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Adam B" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/27651/ X-Sender: "Adam B" References: <20141106002627.10454.25599@reviews.apache.org> In-Reply-To: <20141106002627.10454.25599@reviews.apache.org> Reply-To: "Adam B" X-ReviewRequest-Repository: mesos-git --===============3091435055490799032== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27651/#review60128 ----------------------------------------------------------- Ship it! Great job! All of these Authenticatee reviews have been nearly flawless. Only trivial nits. src/tests/cram_md5_authentication_tests.cpp Not sure why you went from 'T' to 'S' instead of 'U', but it doesn't bother me. src/tests/cram_md5_authentication_tests.cpp s/credentials/credential/ (singular) src/tests/cram_md5_authentication_tests.cpp s/Credentials/Credential/ (singular) - Adam B On Nov. 5, 2014, 4:26 p.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27651/ > ----------------------------------------------------------- > > (Updated Nov. 5, 2014, 4:26 p.m.) > > > Review request for mesos, Adam B and Vinod Kone. > > > Bugs: MESOS-2001 > https://issues.apache.org/jira/browse/MESOS-2001 > > > Repository: mesos-git > > > Description > ------- > > CRAMMD5Authentication tests now cover all default and modularized authenticator/authenticatee combinations. > Also adds a test for missing credentials for the authenticatee. > > > Diffs > ----- > > src/authentication/cram_md5/authenticatee.hpp 3088a77 > src/tests/cram_md5_authentication_tests.cpp 74ea2ad > src/tests/module.hpp 7970c28 > src/tests/module.cpp 482ed22 > > Diff: https://reviews.apache.org/r/27651/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Till Toenshoff > > --===============3091435055490799032==--