Return-Path: X-Original-To: apmail-mesos-dev-archive@www.apache.org Delivered-To: apmail-mesos-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C5BF610416 for ; Mon, 3 Nov 2014 17:06:25 +0000 (UTC) Received: (qmail 81171 invoked by uid 500); 3 Nov 2014 17:06:25 -0000 Delivered-To: apmail-mesos-dev-archive@mesos.apache.org Received: (qmail 81111 invoked by uid 500); 3 Nov 2014 17:06:25 -0000 Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list dev@mesos.apache.org Received: (qmail 81093 invoked by uid 99); 3 Nov 2014 17:06:25 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 03 Nov 2014 17:06:25 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id CAC2F1DFA90; Mon, 3 Nov 2014 17:06:28 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3181681673343660684==" MIME-Version: 1.0 Subject: Re: Review Request 27516: Rebased and re-edited patch for MESOS-1316: "Abstracted out invoking 'mesos-fetcher'". From: "Mesos ReviewBot" To: "Benjamin Hindman" Cc: "Mesos ReviewBot" , "Bernd Mathiske" , "mesos" Date: Mon, 03 Nov 2014 17:06:28 -0000 Message-ID: <20141103170628.10454.67854@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Mesos ReviewBot" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/27516/ X-Sender: "Mesos ReviewBot" References: <20141103163650.10454.61495@reviews.apache.org> In-Reply-To: <20141103163650.10454.61495@reviews.apache.org> Reply-To: "Mesos ReviewBot" X-ReviewRequest-Repository: mesos-git --===============3181681673343660684== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27516/#review59587 ----------------------------------------------------------- Patch looks great! Reviews applied: [27516] All tests passed. - Mesos ReviewBot On Nov. 3, 2014, 4:36 p.m., Bernd Mathiske wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27516/ > ----------------------------------------------------------- > > (Updated Nov. 3, 2014, 4:36 p.m.) > > > Review request for mesos and Benjamin Hindman. > > > Bugs: MESOS-1316 > https://issues.apache.org/jira/browse/MESOS-1316 > > > Repository: mesos-git > > > Description > ------- > > Manually rebasing and re-editing https://reviews.apache.org/r/21233/, which is supposed to be replaced now by this patch. > > Original description: "To test the mesos-fetcher (and the setting of the environment) more cleanly I did some refactoring into a 'fetcher' namespace." > > Also moved fetcher environment tests to fetcher test file. Added two fetcher tests. > > > Diffs > ----- > > src/Makefile.am e6a07150c10b9fa040143e394b2f913a18eeebc1 > src/launcher/fetcher.cpp 9323c28237010fa065ef34d74435c151ded530a8 > src/slave/containerizer/fetcher.hpp PRE-CREATION > src/slave/containerizer/fetcher.cpp PRE-CREATION > src/slave/containerizer/mesos/containerizer.cpp d4b08f54d6feb453f3a9d27ca54c867176e62102 > src/tests/containerizer_tests.cpp 2c90d2fc18a3268c55b6dfe98699bfb36d093983 > src/tests/fetcher_tests.cpp d7754009a59fedb43e3422c56b3a786ce80164aa > > Diff: https://reviews.apache.org/r/27516/diff/ > > > Testing > ------- > > make check on Mac OS 10.10 and Ubuntu 14.4. > > In total, 3 tests fail: ExamplesTest.NoExecutorFramework, ExamplesTest.JavaFramework > , ExamplesTest.PythonFramework. It is strongly suspected that those are unrelated to this code change and just generally flaky. > > > Thanks, > > Bernd Mathiske > > --===============3181681673343660684==--