Return-Path: X-Original-To: apmail-mesos-dev-archive@www.apache.org Delivered-To: apmail-mesos-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D4B4C179C4 for ; Sat, 1 Nov 2014 17:25:27 +0000 (UTC) Received: (qmail 44169 invoked by uid 500); 1 Nov 2014 17:25:27 -0000 Delivered-To: apmail-mesos-dev-archive@mesos.apache.org Received: (qmail 44103 invoked by uid 500); 1 Nov 2014 17:25:27 -0000 Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list dev@mesos.apache.org Received: (qmail 44084 invoked by uid 99); 1 Nov 2014 17:25:26 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 01 Nov 2014 17:25:26 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 047591DFA7F; Sat, 1 Nov 2014 17:25:31 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3320485540679308580==" MIME-Version: 1.0 Subject: Re: Review Request 26736: Ensure docker calls stop if a docker_stop_timeout is provided Added the flag docker_stop_timeout that defaults to 0, if the timeout is 0 the a docker kill will be run, otherwise a docker stop with the timeout in seconds is used. A negative value will result in a Failure. From: "Timothy Chen" To: "Timothy Chen" , "Ankur Chauhan" , "mesos" , "Ryan Thomas" Date: Sat, 01 Nov 2014 17:25:31 -0000 Message-ID: <20141101172531.7137.23238@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Timothy Chen" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/26736/ X-Sender: "Timothy Chen" References: <20141101171335.7137.36888@reviews.apache.org> In-Reply-To: <20141101171335.7137.36888@reviews.apache.org> Reply-To: "Timothy Chen" X-ReviewRequest-Repository: mesos-git --===============3320485540679308580== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26736/#review59469 ----------------------------------------------------------- src/tests/docker_containerizer_tests.cpp This is not needed, but I'll remove it for you. src/tests/docker_containerizer_tests.cpp This is not needed, but I'll remove it for you. - Timothy Chen On Nov. 1, 2014, 5:13 p.m., Ryan Thomas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26736/ > ----------------------------------------------------------- > > (Updated Nov. 1, 2014, 5:13 p.m.) > > > Review request for mesos. > > > Bugs: MESOS-1925 > https://issues.apache.org/jira/browse/MESOS-1925 > > > Repository: mesos-git > > > Description > ------- > > Ensure docker calls stop if a docker_stop_timeout is provided Added the flag docker_stop_timeout that defaults to 0, if the timeout is 0 the a docker kill will be run, otherwise a docker stop with the timeout in seconds is used. A negative value will result in a Failure. > > > Diffs > ----- > > src/docker/docker.hpp 2dc692c51d6f9d45d8d7c59f8678991fd80c6e89 > src/docker/docker.cpp 0c0a1bfd3c1260ebdf342d0a6e0e04d7b6a111a4 > src/slave/containerizer/docker.cpp a6689203adbdcb0ad12583389eaeb83329e4ef6b > src/slave/flags.hpp 319c002c66212ffb11759dbcc39f7661203a3e4e > src/tests/docker_containerizer_tests.cpp 9d4ccc57f58d61c62aab5cdc79a129e987920bf6 > src/tests/docker_tests.cpp ff06a01d7f20656c05bcf5afd3bc10059dc5378d > > Diff: https://reviews.apache.org/r/26736/diff/ > > > Testing > ------- > > make check > sudo bin/mesos-tests.sh --gtest_filter="DOCKER" --verbose > support/mesos-style.py > > > Thanks, > > Ryan Thomas > > --===============3320485540679308580==--