mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jie Yu" <yujie....@gmail.com>
Subject Re: Review Request 28364: Refactored Master::_launchTasks().
Date Mon, 24 Nov 2014 18:20:56 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28364/#review62829
-----------------------------------------------------------

Ship it!



src/master/master.cpp
<https://reviews.apache.org/r/28364/#comment104956>

    Reorder these two such that it's consistent with the following code (push to validTasks
first and then update usedResources).


- Jie Yu


On Nov. 22, 2014, 1:44 a.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28364/
> -----------------------------------------------------------
> 
> (Updated Nov. 22, 2014, 1:44 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Needed for subsequent review where slave needs to be informed about persistent resources
before the tasks reach it.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp 6eabb07f0947242c74b2bcc9e2b57b0f727c2917 
>   src/master/master.cpp 5957db6538c1c66a4cc42c14f3908c0c2cc35f39 
> 
> Diff: https://reviews.apache.org/r/28364/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message