mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request 28293: Changed master label test to strictly enforce format.
Date Thu, 20 Nov 2014 20:36:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28293/#review62411
-----------------------------------------------------------

Ship it!



src/tests/master_tests.cpp
<https://reviews.apache.org/r/28293/#comment104460>

    Hm.. sharing the same key is allowed? What about same key, but with no values?
    
    e.g. 
    
    key = "foo"
    key = "foo"
    
    Is that allowed? What would be the point of that?


- Ben Mahler


On Nov. 20, 2014, 7:37 p.m., Niklas Nielsen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28293/
> -----------------------------------------------------------
> 
> (Updated Nov. 20, 2014, 7:37 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Timothy Chen.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See description.
> 
> 
> Diffs
> -----
> 
>   src/tests/master_tests.cpp 21a642f2e001e13e3a8881803a5d0cdbee36dd67 
> 
> Diff: https://reviews.apache.org/r/28293/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Niklas Nielsen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message