mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Hindman" <b...@berkeley.edu>
Subject Re: Review Request 28190: Add option to force pull docker image
Date Thu, 20 Nov 2014 19:54:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28190/#review62399
-----------------------------------------------------------

Ship it!



src/docker/docker.hpp
<https://reviews.apache.org/r/28190/#comment104449>

    Why isn't s/forcePullImage/force/ sufficient for the parameter name? This function is
called 'pull' and we know we're pulling an image, we just need to figure out if we should
force it or not.



src/slave/containerizer/docker.hpp
<https://reviews.apache.org/r/28190/#comment104450>

    On the other hand, seems like this one _should_ be called 'forcePullImage' though since
it is just a helper for getting the 'force_pull_image' protobuf field. All the other 'forcePullImage'
are just 'force' added to Docker::pull though.


- Benjamin Hindman


On Nov. 19, 2014, 12:13 a.m., Timothy Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28190/
> -----------------------------------------------------------
> 
> (Updated Nov. 19, 2014, 12:13 a.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Bugs: MESOS-1886
>     https://issues.apache.org/jira/browse/MESOS-1886
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Add option to force pull docker image
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 35b91180f4e317c47dfdd18e9f7fca28143ae8f5 
>   src/docker/docker.hpp f004879cab8524a5c765a42a2216f22e2e9a1f0a 
>   src/docker/docker.cpp f2730a733fbabea90e9395de85c0668a29ccc530 
>   src/slave/containerizer/docker.hpp f9f3ffb5a407a34e7ec2dc317921d67cfeba1281 
>   src/slave/containerizer/docker.cpp 6213198f9ee6227d77461aef2b3a012d51b6535c 
>   src/tests/docker_containerizer_tests.cpp 59c2beb1907b4c6b5782b7c848c5c5116b9de272 
> 
> Diff: https://reviews.apache.org/r/28190/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message