mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Niklas Nielsen" <...@qni.dk>
Subject Re: Review Request 28287: Simplify Label JSON modeling with JSON::Protobuf
Date Thu, 20 Nov 2014 19:15:20 GMT


> On Nov. 20, 2014, 11:03 a.m., Ben Mahler wrote:
> > Moving to JSON::Protobuf requires that we strictly enforce the format as part of
the tests, to avoid accidentally breaking the http api. Just to confirm, would the tests break
if the Label protobuf is changed? If not, let's make sure a test will catch it.

Right now, the tests only verifies known fields: https://github.com/apache/mesos/blob/master/src/tests/master_tests.cpp#L2662
So would it be more robust to test as we do in HTTP.ModelTask? I can do that in a subsequent
review.


- Niklas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28287/#review62384
-----------------------------------------------------------


On Nov. 20, 2014, 10:20 a.m., Niklas Nielsen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28287/
> -----------------------------------------------------------
> 
> (Updated Nov. 20, 2014, 10:20 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Timothy Chen.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> JSON fields doesn't need to be set explicitly, so label modeling can be simplified with
JSON::Protobuf.
> 
> 
> Diffs
> -----
> 
>   src/common/http.cpp b21e18d547d716e540dc2ce47b2cb1ab898bce94 
> 
> Diff: https://reviews.apache.org/r/28287/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Niklas Nielsen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message