mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Review Request 28267: Updated killTask to perform reconciliation for unknown tasks.
Date Thu, 20 Nov 2014 00:24:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28267/
-----------------------------------------------------------

Review request for mesos and Vinod Kone.


Bugs: MESOS-2127
    https://issues.apache.org/jira/browse/MESOS-2127


Repository: mesos-git


Description
-------

Per MESOS-2127:

Currently, killTask uses its own reconciliation logic, which has diverged from the reconcileTasks
logic. Specifically, when the task is unknown and a non-strict registry is in use, killTask
will not send TASK_LOST whereas reconcileTask will.

We should make these consistent.


Diffs
-----

  src/master/master.cpp de42f8eb7c3c4ed64fb7fea9f4977e276f4a9043 
  src/tests/reconciliation_tests.cpp 4ba53940951584d9baa2c7aa4e124814471206bc 

Diff: https://reviews.apache.org/r/28267/diff/


Testing
-------

Added a test and ran all the reconciliation tests in repetition.


Thanks,

Ben Mahler


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message