mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joris Van Remoortere" <joris.van.remoort...@gmail.com>
Subject Re: Review Request 28205: Removing trailing diff/ from Review line in commit message.
Date Wed, 19 Nov 2014 22:29:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28205/
-----------------------------------------------------------

(Updated Nov. 19, 2014, 10:29 p.m.)


Review request for mesos, Benjamin Hindman and Niklas Nielsen.


Changes
-------

Add comment explaining why we're removing the trailing diff/.


Repository: mesos-git


Description
-------

See summary.


Diffs (updated)
-----

  include/mesos/resources.hpp 10777a62492e4a3333d764e0f75c064694e054d1 
  src/Makefile.am 1d4ba1c8335eb8106cbccf903eaf3d9fdebdcda2 
  src/cli/execute.cpp 77deec91177c90a8a20ccd4fe063b82ca08cefbd 
  src/common/resources.cpp 61d16a88bb1300c343c4f3141d5a068dbba933bd 
  src/common/values.cpp 597c4520ebc8d31a606f433593ae41c003683eb3 
  src/examples/low_level_scheduler_libprocess.cpp e5267f7c8da018aaa46de65b85220916fed1b4cf

  src/examples/low_level_scheduler_pthread.cpp 4f9a59401ffe6950a34c1a518d355974e70ac7d2 
  src/examples/no_executor_framework.cpp 5e47cfcfa1677052be114f8a9b0e24f6ef0238d9 
  src/examples/test_framework.cpp e5ec3b9f75446980ce9235209b8b74128e3e5e39 
  src/master/drf_sorter.cpp 0ad6c52759e1ceec4b43f99d8fa1e75d7e2e1c31 
  src/master/hierarchical_allocator_process.hpp e631b60daf6333b6dfeca7ab4082e745eb963b4b 
  src/master/http.cpp 9157a41e543cfa60e708ae21d5968b21ad6cb08e 
  src/master/master.cpp de42f8eb7c3c4ed64fb7fea9f4977e276f4a9043 
  src/master/metrics.hpp 6a43abc914dce24c60b5db57ee01d172c8258e82 
  src/master/metrics.cpp 956fe5042d7478d90d4f03059e248694ba2b95e5 
  src/slave/containerizer/containerizer.cpp 1448bea141412c7d0eedc24c3e0b10014eea16ec 
  src/slave/metrics.hpp 0390461968112cac9ed84ec3cc23b264e8b4e9d7 
  src/slave/metrics.cpp c32b4d8a1ff3bc5e5f5ca21eb78a036c9ea1a813 
  src/slave/slave.hpp c6d11ef2de77738ab46d7ca02778f7237d230a5c 
  src/slave/slave.cpp 373c8b44f5bc000da801b0925e1a9c346d9ffabf 
  src/tests/gc_tests.cpp cb5dc5fa720bd2f344a9c7a3748dbe6f898705ca 
  src/tests/mesos.hpp f132c6caff471ce1be069f31eadb1d7e5d0f7dfd 
  src/tests/metrics_tests.cpp 7512b908ec1cbf80b74b768613a5f7925fa2249e 
  src/tests/resource_offers_tests.cpp 7e09319727992505b0b98af0943f9541c5d182e2 
  src/tests/resources_tests.cpp 73f50ba4f5c5db591180edd1fef1a3ecf6e03185 
  src/tests/slave_recovery_tests.cpp 782f57a4d76481f3e39f076cf1fca6e3c9ebf311 
  src/tests/values_tests.cpp 35d3b3e8a619d20256db776979cea6618fa10f75 
  support/post-reviews.py 33c95fad1089286442010f37d1edea5434a0a7a6 

Diff: https://reviews.apache.org/r/28205/diff/


Testing
-------

Submitted this review using post-review.
Commit message review line:
Review: https://reviews.apache.org/r/28205


Thanks,

Joris Van Remoortere


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message