mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Adam B" <a...@mesosphere.io>
Subject Re: Review Request 28260: Added slave active field in state.json.
Date Wed, 19 Nov 2014 21:38:32 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28260/#review62237
-----------------------------------------------------------

Ship it!


LGTM! 1 line change, and a 60 line unit test.


src/tests/master_tests.cpp
<https://reviews.apache.org/r/28260/#comment104247>

    s/'active/'active'/


- Adam B


On Nov. 19, 2014, 1:30 p.m., Niklas Nielsen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28260/
> -----------------------------------------------------------
> 
> (Updated Nov. 19, 2014, 1:30 p.m.)
> 
> 
> Review request for mesos, Adam B and Vinod Kone.
> 
> 
> Bugs: MESOS-2124
>     https://issues.apache.org/jira/browse/MESOS-2124
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See description.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp 9157a41e543cfa60e708ae21d5968b21ad6cb08e 
>   src/tests/master_tests.cpp b629cf7bab31abe2c9b05bef4203a4c253da506a 
> 
> Diff: https://reviews.apache.org/r/28260/diff/
> 
> 
> Testing
> -------
> 
> make check (added new MasterTest.SlaveActiveEndpoint test)
> 
> 
> Thanks,
> 
> Niklas Nielsen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message