mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request 28256: Add tryInsert to hashmap
Date Wed, 19 Nov 2014 21:09:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28256/#review62231
-----------------------------------------------------------



3rdparty/libprocess/3rdparty/stout/include/stout/hashmap.hpp
<https://reviews.apache.org/r/28256/#comment104241>

    Doesn't look like you need this? Can't you just compoase .contains() and .put() in the
caller?


- Ben Mahler


On Nov. 19, 2014, 9:01 p.m., Cody Maloney wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28256/
> -----------------------------------------------------------
> 
> (Updated Nov. 19, 2014, 9:01 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Add tryInsert to hashmap
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/hashmap.hpp aa4d9ba68a27c1a7dea8cfe948a90487c4708add

>   3rdparty/libprocess/3rdparty/stout/tests/hashmap_tests.cpp eb3abfc9ba62f92d2ed5bc0e1c093791003a8319

> 
> Diff: https://reviews.apache.org/r/28256/diff/
> 
> 
> Testing
> -------
> 
> make distcheck ubuntu 14.04
> 
> 
> Thanks,
> 
> Cody Maloney
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message