mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Hindman" <b...@berkeley.edu>
Subject Re: Review Request 28154: Added task labels to mesos.proto
Date Tue, 18 Nov 2014 23:10:22 GMT


> On Nov. 18, 2014, 10:50 p.m., Benjamin Hindman wrote:
> > include/mesos/mesos.proto, line 939
> > <https://reviews.apache.org/r/28154/diff/2/?file=768090#file768090line939>
> >
> >     I recall recently I wanted to use Parameters but without having to set the value.
Do you forsee something similar? Should we make 'value' be optional?
> 
> Niklas Nielsen wrote:
>     Yup - let's do that. I did this to mimic parameters.

We should make the value in Parameters optional too (assuming we can), and make any changes
necessary throughout the code base.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28154/#review62038
-----------------------------------------------------------


On Nov. 18, 2014, 10:39 p.m., Niklas Nielsen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28154/
> -----------------------------------------------------------
> 
> (Updated Nov. 18, 2014, 10:39 p.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Bugs: MESOS-2120
>     https://issues.apache.org/jira/browse/MESOS-2120
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See description.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 35b91180f4e317c47dfdd18e9f7fca28143ae8f5 
> 
> Diff: https://reviews.apache.org/r/28154/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Niklas Nielsen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message