mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dominic Hamon" <dha...@twopensource.com>
Subject Re: Review Request 28058: Pull Metrics struct out of Slave class.
Date Tue, 18 Nov 2014 20:07:40 GMT


> On Nov. 18, 2014, 11:49 a.m., Vinod Kone wrote:
> > src/tests/metrics_tests.cpp, lines 152-153
> > <https://reviews.apache.org/r/28058/diff/2/?file=767560#file767560line152>
> >
> >     Why start the master?

when i didn't, the slave complained that no master could be found and the test failed.


- Dominic


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28058/#review61991
-----------------------------------------------------------


On Nov. 18, 2014, 10:41 a.m., Dominic Hamon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28058/
> -----------------------------------------------------------
> 
> (Updated Nov. 18, 2014, 10:41 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-2051
>     https://issues.apache.org/jira/browse/MESOS-2051
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> see summary
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 0fe7dd067b80cfe802201482eed63a30ac8dcbd4 
>   src/master/metrics.hpp 5e6b6d55ce03727f25140379c15d08bd5d70df38 
>   src/master/metrics.cpp a7ac96d34bbd84b5df74e1434624340d55b8651a 
>   src/slave/metrics.hpp PRE-CREATION 
>   src/slave/metrics.cpp PRE-CREATION 
>   src/slave/slave.hpp 29bea655a4ba8c99b3a81108b9224b8476927761 
>   src/slave/slave.cpp 06b2e18ff9b202c30f8bf4378cdd35aef734337f 
>   src/tests/metrics_tests.cpp 72571f2d71cd2f66381a50bc6a661e91e431f124 
> 
> Diff: https://reviews.apache.org/r/28058/diff/
> 
> 
> Testing
> -------
> 
> added new test and ran make check
> 
> 
> Thanks,
> 
> Dominic Hamon
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message