mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Niklas Nielsen" <...@qni.dk>
Subject Re: Review Request 28125: Fix compilation error for Socket on older linux + OSX.
Date Mon, 17 Nov 2014 19:05:32 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28125/#review61773
-----------------------------------------------------------

Ship it!


LGTM modulo Ben's comment

We could think about making process::socket more robust and introduce our own SocketOption
enum - that would make it easier to read and harder to use wrong :-)

- Niklas Nielsen


On Nov. 17, 2014, 10:47 a.m., Joris Van Remoortere wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28125/
> -----------------------------------------------------------
> 
> (Updated Nov. 17, 2014, 10:47 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Niklas Nielsen, Till Toenshoff, and Vinod
Kone.
> 
> 
> Bugs: MESOS-2116
>     https://issues.apache.org/jira/browse/MESOS-2116
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Test whether SOCK_NONBLOCK and SOCK_CLOEXEC are defined to use single system call to
create socket.
> Otherwise use os::nonblock and os::cloexec after creating the socket.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/socket.hpp 20136ba4c65883b8bbcc8498e09f7ff7b50b68a4

> 
> Diff: https://reviews.apache.org/r/28125/diff/
> 
> 
> Testing
> -------
> 
> make check on linux
> make check on macos
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message