mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Hindman" <b...@berkeley.edu>
Subject Re: Review Request 27504: Started moving libev specific functionality out of process.cpp.
Date Sun, 16 Nov 2014 00:25:00 GMT


> On Nov. 14, 2014, 9:44 p.m., Dominic Hamon wrote:
> > 3rdparty/libprocess/src/libev.cpp, line 14
> > <https://reviews.apache.org/r/27504/diff/1/?file=747117#file747117line14>
> >
> >     there's no guarantee when this static construction will happen. this should
almost certainly be a function that returns a static queue.
> 
> Benjamin Hindman wrote:
>     Where does the specification say that?
> 
> Dominic Hamon wrote:
>     http://www.parashift.com/c++-faq-lite/static-init-order.html explains it
>     
>     nothing guarantees that the static construction of watchers has been completed before
methods are called that mutate watchers.

Yes, I agree that if any of these variables depended on each other for construction then we
couldn't do it this way, but each of these variables is independent during construction, so
this should not be a problem. Unless I'm missing something?


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27504/#review61511
-----------------------------------------------------------


On Nov. 14, 2014, 11:17 p.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27504/
> -----------------------------------------------------------
> 
> (Updated Nov. 14, 2014, 11:17 p.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere and Niklas Nielsen.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/Makefile.am a55d5620d34fcd483459155c5f66aa0e5b2b7c68 
>   3rdparty/libprocess/src/libev.hpp PRE-CREATION 
>   3rdparty/libprocess/src/libev.cpp PRE-CREATION 
>   3rdparty/libprocess/src/process.cpp 5842705ae78ebe36c1c01bfcd468e9ebe55de3be 
> 
> Diff: https://reviews.apache.org/r/27504/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message