mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Park" <mcyp...@gmail.com>
Subject Re: Review Request 28089: Refactored operators for Resource object and made them private.
Date Sun, 16 Nov 2014 00:05:28 GMT


> On Nov. 15, 2014, 11:15 p.m., Michael Park wrote:
> > src/common/resources.cpp, lines 800-804
> > <https://reviews.apache.org/r/28089/diff/1/?file=764759#file764759line800>
> >
> >     I know you didn't touch this part, but could you make it so that `Resources
Resources::operator + (const Resource& that) const` is implemented in terms of this instead
of the other way around?
> >     
> >     Pretty much the exact same pattern as what you did for `Resource& operator
+= (Resource& left, const Resource& right)` and `Resource operator + (const Resource&
left, const Resource& right)`.

Aweomse, this is already done in https://reviews.apache.org/r/28091/


- Michael


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28089/#review61669
-----------------------------------------------------------


On Nov. 15, 2014, 6:56 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28089/
> -----------------------------------------------------------
> 
> (Updated Nov. 15, 2014, 6:56 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Vinod Kone.
> 
> 
> Bugs: MESOS-1974
>     https://issues.apache.org/jira/browse/MESOS-1974
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Hide operators for Resource object. Split "matches" to handle future first class infos.
> 
> 
> Diffs
> -----
> 
>   include/mesos/resources.hpp 0e37170 
>   src/common/resources.cpp e9a0c85 
>   src/tests/resources_tests.cpp 3e50889 
> 
> Diff: https://reviews.apache.org/r/28089/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message