mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request 28092: Removed public operators for repeated Resource protobuf.
Date Sat, 15 Nov 2014 19:22:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28092/#review61654
-----------------------------------------------------------



include/mesos/resources.hpp
<https://reviews.apache.org/r/28092/#comment103396>

    Just curious, did we even need this in the first place? Looks like implicit conversion
will result in us using the 'Resources' stream operator?



include/mesos/resources.hpp
<https://reviews.apache.org/r/28092/#comment103397>

    So implicit conversion is not enough for the tests to remain unchanged? Seems a bit too
clunky without these operators IMO.


- Ben Mahler


On Nov. 15, 2014, 7:11 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28092/
> -----------------------------------------------------------
> 
> (Updated Nov. 15, 2014, 7:11 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Vinod Kone.
> 
> 
> Bugs: MESOS-1974
>     https://issues.apache.org/jira/browse/MESOS-1974
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Those interfaces are not good because repeated Resource ptr is not validated (and flattened).
> 
> 
> Diffs
> -----
> 
>   include/mesos/resources.hpp 0e37170 
>   src/tests/master_tests.cpp 66423a9 
> 
> Diff: https://reviews.apache.org/r/28092/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message