mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joris Van Remoortere" <joris.van.remoort...@gmail.com>
Subject Re: Review Request 27966: Add bind(), listen(), and accept() to Socket interface. Use these in process.cpp.
Date Sat, 15 Nov 2014 05:11:50 GMT


> On Nov. 15, 2014, 12:58 a.m., Benjamin Hindman wrote:
> > 3rdparty/libprocess/src/poll.cpp, line 121
> > <https://reviews.apache.org/r/27966/diff/2/?file=764063#file764063line121>
> >
> >     Why don't we need to call process::initialize anymore?

Put this back now that we moved the accept call down in the initializer.


> On Nov. 15, 2014, 12:58 a.m., Benjamin Hindman wrote:
> > 3rdparty/libprocess/src/process.cpp, lines 791-793
> > <https://reviews.apache.org/r/27966/diff/2/?file=764064#file764064line791>
> >
> >     Why do you need to make the copy explicitly?

this was done because we were using onReady / onFailed. Since we use onAny we don't need to
do this anymore.


- Joris


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27966/#review61583
-----------------------------------------------------------


On Nov. 14, 2014, 10:52 p.m., Joris Van Remoortere wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27966/
> -----------------------------------------------------------
> 
> (Updated Nov. 14, 2014, 10:52 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Niklas Nielsen.
> 
> 
> Bugs: MESOS-1330
>     https://issues.apache.org/jira/browse/MESOS-1330
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See Summary.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/socket.hpp 66838814236fc064a2463399fb15f4a815879bf5

>   3rdparty/libprocess/src/libev.hpp PRE-CREATION 
>   3rdparty/libprocess/src/libev.cpp PRE-CREATION 
>   3rdparty/libprocess/src/poll.cpp PRE-CREATION 
>   3rdparty/libprocess/src/process.cpp a34b8702b01dec9c954552de0b923866d172c453 
> 
> Diff: https://reviews.apache.org/r/27966/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message