mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joris Van Remoortere" <joris.van.remoort...@gmail.com>
Subject Re: Review Request 27957: Use std::shared_ptr to do reference counting for libprocess
Date Sat, 15 Nov 2014 02:28:29 GMT


> On Nov. 15, 2014, 1:34 a.m., Benjamin Hindman wrote:
> > 3rdparty/libprocess/include/process/socket.hpp, line 44
> > <https://reviews.apache.org/r/27957/diff/2/?file=763954#file763954line44>
> >
> >     s/Impl/Implementation/
> >     
> >     Even though its a long word, let's set the precendent for all the other classes
that we want to use this pattern for.

Sticking with Impl right now.


- Joris


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27957/#review61563
-----------------------------------------------------------


On Nov. 14, 2014, 8:06 p.m., Joris Van Remoortere wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27957/
> -----------------------------------------------------------
> 
> (Updated Nov. 14, 2014, 8:06 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Niklas Nielsen.
> 
> 
> Bugs: MESOS-1330
>     https://issues.apache.org/jira/browse/MESOS-1330
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Use std::shared_ptr to do reference counting for libprocess rather than manually doing
it.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/socket.hpp 66838814236fc064a2463399fb15f4a815879bf5

> 
> Diff: https://reviews.apache.org/r/27957/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message