mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Hindman" <b...@berkeley.edu>
Subject Re: Review Request 27961: Use socket.read() for ignore_data in process.cpp
Date Sat, 15 Nov 2014 00:39:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27961/#review61574
-----------------------------------------------------------

Ship it!



3rdparty/libprocess/src/process.cpp
<https://reviews.apache.org/r/27961/#comment103294>

    Do you really want/need this to be const?



3rdparty/libprocess/src/process.cpp
<https://reviews.apache.org/r/27961/#comment103295>

    s/socketPtr/new Socket(socket)/
    
    And then you can kill socketPtr above. ;-)


- Benjamin Hindman


On Nov. 14, 2014, 9:51 p.m., Joris Van Remoortere wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27961/
> -----------------------------------------------------------
> 
> (Updated Nov. 14, 2014, 9:51 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Niklas Nielsen.
> 
> 
> Bugs: MESOS-1330
>     https://issues.apache.org/jira/browse/MESOS-1330
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See Summary.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/process.cpp a34b8702b01dec9c954552de0b923866d172c453 
> 
> Diff: https://reviews.apache.org/r/27961/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message