mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Hindman" <b...@berkeley.edu>
Subject Re: Review Request 27504: Started moving libev specific functionality out of process.cpp.
Date Fri, 14 Nov 2014 23:01:27 GMT


> On Nov. 14, 2014, 9:44 p.m., Dominic Hamon wrote:
> > 3rdparty/libprocess/src/libev.cpp, line 14
> > <https://reviews.apache.org/r/27504/diff/1/?file=747117#file747117line14>
> >
> >     there's no guarantee when this static construction will happen. this should
almost certainly be a function that returns a static queue.

Where does the specification say that?


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27504/#review61511
-----------------------------------------------------------


On Nov. 14, 2014, 9:39 p.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27504/
> -----------------------------------------------------------
> 
> (Updated Nov. 14, 2014, 9:39 p.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere and Niklas Nielsen.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/Makefile.am a55d5620d34fcd483459155c5f66aa0e5b2b7c68 
>   3rdparty/libprocess/src/libev.hpp PRE-CREATION 
>   3rdparty/libprocess/src/libev.cpp PRE-CREATION 
>   3rdparty/libprocess/src/process.cpp 85fb9958342f0bcdde322d9c55333126e6f86668 
> 
> Diff: https://reviews.apache.org/r/27504/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message