mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request 27923: Use Slave::getExecutorInfo() only once.
Date Fri, 14 Nov 2014 19:12:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27923/#review61480
-----------------------------------------------------------



src/tests/mesos.cpp
<https://reviews.apache.org/r/27923/#comment103131>

    Are you not using the commit hook?
    
    >>> len('  slave::Slave::_runTask(future, frameworkInfo, frameworkId, pid, task,
executorInfo);')
    86


- Ben Mahler


On Nov. 12, 2014, 8:57 p.m., Ian Downes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27923/
> -----------------------------------------------------------
> 
> (Updated Nov. 12, 2014, 8:57 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-1718
>     https://issues.apache.org/jira/browse/MESOS-1718
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Use Slave::getExecutorInfo() only once.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.hpp d9f9d2e90dd4037f5cd6331c003aafb95b278a01 
>   src/slave/slave.cpp ba00bf5e4d017fe5d18826a7e484d50ed692d10a 
>   src/tests/mesos.hpp c1d64a73ff2312a10d4e809072d219e60c28a76f 
>   src/tests/mesos.cpp 3b98c69a604132be71a60fbbee4a47b51fe6956a 
>   src/tests/slave_tests.cpp 18ff8fe499943d209549d9924558d6e84ce78fec 
> 
> Diff: https://reviews.apache.org/r/27923/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ian Downes
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message