mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mesos ReviewBot" <...@mesos.apache.org>
Subject Re: Review Request 27995: Refactoring fetcher code a bit more (MESOS-2056) in preparation of fetcher cache
Date Fri, 14 Nov 2014 14:25:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27995/#review61439
-----------------------------------------------------------


Patch looks great!

Reviews applied: [27995]

All tests passed.

- Mesos ReviewBot


On Nov. 14, 2014, 1:57 p.m., Bernd Mathiske wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27995/
> -----------------------------------------------------------
> 
> (Updated Nov. 14, 2014, 1:57 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Timothy Chen.
> 
> 
> Bugs: MESOS-2056
>     https://issues.apache.org/jira/browse/MESOS-2056
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> As a follow up to MESOS-1316, moved all fetcher run code into fetcher name space. 
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/docker.cpp 5978ec2fcf91c127ed7a8f12ee3a47e57f4c0f1b 
>   src/slave/containerizer/fetcher.hpp 7c578096c53c5f791593f83bdc2c0f84e5050872 
>   src/slave/containerizer/fetcher.cpp a04f0a83f248102ae573dcb6c2f7eb7400589da1 
>   src/slave/containerizer/mesos/containerizer.cpp 562b03bb7368efc3878763e93866ce7789ac78c6

>   src/tests/fetcher_tests.cpp 19aee3103ed56208f602cbe556be7a797d59bb39 
> 
> Diff: https://reviews.apache.org/r/27995/diff/
> 
> 
> Testing
> -------
> 
> make check. 
> 
> sudo make check on Linux is pending.
> 
> 
> Thanks,
> 
> Bernd Mathiske
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message