mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Cody Maloney" <c...@mesosphere.io>
Subject Re: Review Request 27605: Add a unit test to stout path
Date Thu, 13 Nov 2014 00:39:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27605/
-----------------------------------------------------------

(Updated Nov. 13, 2014, 12:39 a.m.)


Review request for mesos and Ben Mahler.


Changes
-------

Add more comments, add dependencies to make review bot happy + configure check.


Bugs: MESOS-1733 and mesos-1877
    https://issues.apache.org/jira/browse/MESOS-1733
    https://issues.apache.org/jira/browse/mesos-1877


Repository: mesos-git


Description
-------

Add a unit test to stout path to increase confidence when changing the code.


Diffs (updated)
-----

  3rdparty/libprocess/3rdparty/stout/Makefile.am 7aac3fdb864e838cdd4e0d817ed4dff14923c69d

  3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp bc6920a24d920c809e36a2a3da1810e52d0db101

  3rdparty/libprocess/3rdparty/stout/tests/path_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/27605/diff/


Testing
-------

make distcheck on Ubuntu 14.04

NOTE: ReviewBot is going to be unhappy about this "crossing" stout and libprocess... I'm not
sure what the correct fix for reviewbot is in this case, since the Makefile does really cross
the project bounds...


Thanks,

Cody Maloney


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message