mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joris Van Remoortere" <joris.van.remoort...@gmail.com>
Subject Re: Review Request 27356: Introduce enable_shared_from_this configure check
Date Wed, 12 Nov 2014 19:27:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27356/
-----------------------------------------------------------

(Updated Nov. 12, 2014, 7:27 p.m.)


Review request for mesos, Benjamin Hindman and Dominic Hamon.


Changes
-------

Update comment style.
Use shared_from_this() to address Nik's concern.


Bugs: MESOS-2012
    https://issues.apache.org/jira/browse/MESOS-2012


Repository: mesos-git


Description
-------

* Introduce enable_shared_from_this to the configure check
* Document availability of enable_shared_from_this in style guide


Diffs (updated)
-----

  docs/mesos-c++-style-guide.md f50354c 
  m4/ax_cxx_compile_stdcxx_11.m4 72a1080 

Diff: https://reviews.apache.org/r/27356/diff/


Testing
-------

make check on gcc-4.4
make check on gcc-4.9


Thanks,

Joris Van Remoortere


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message