mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request 27831: Abort if Future::failure() is called on non-failed Future
Date Mon, 10 Nov 2014 22:38:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27831/#review60694
-----------------------------------------------------------

Ship it!



3rdparty/libprocess/include/process/future.hpp
<https://reviews.apache.org/r/27831/#comment102075>

    Hm.. not sure why 'message' is on the heap in the first place, but we can save that for
later.


- Ben Mahler


On Nov. 10, 2014, 10:26 p.m., Dominic Hamon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27831/
> -----------------------------------------------------------
> 
> (Updated Nov. 10, 2014, 10:26 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: mesos-1694
>     https://issues.apache.org/jira/browse/mesos-1694
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> see summary
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/future.hpp 46ae16b0bbce79005f5ed8711be663eeeb8f4bcf

> 
> Diff: https://reviews.apache.org/r/27831/diff/
> 
> 
> Testing
> -------
> 
> make check
> ./build/bin/mesos-local.sh
> 
> 
> Thanks,
> 
> Dominic Hamon
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message