mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Till Toenshoff" <toensh...@me.com>
Subject Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.
Date Sun, 09 Nov 2014 21:32:00 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27760/
-----------------------------------------------------------

(Updated Nov. 9, 2014, 9:32 p.m.)


Review request for mesos, Adam B, Kapil Arya, Niklas Nielsen, and Vinod Kone.


Bugs: MESOS-2050
    https://issues.apache.org/jira/browse/MESOS-2050


Repository: mesos-git


Description
-------

The initial design and implementation of the authenticator module interface caused issues
and was not optimal for heavy lifting setup of external dependencies. By introducing a two
fold design, this has been decoupled from the authentication message processing. The new design
also gets us back on track to the goal of makeing SASL a soft dependency of mesos.


Diffs (updated)
-----

  src/authentication/authenticator.hpp 460494a 
  src/authentication/cram_md5/authenticator.hpp a23bf5d 
  src/master/master.hpp 687f178 
  src/master/master.cpp 5712b17 
  src/tests/cram_md5_authentication_tests.cpp 1ed2312 

Diff: https://reviews.apache.org/r/27760/diff/


Testing
-------

make check


Thanks,

Till Toenshoff


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message