mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Adam B" <a...@mesosphere.io>
Subject Re: Review Request 27651: Updated CRAMMD5Authentication tests to additionally run against the test authenticatee module.
Date Thu, 06 Nov 2014 06:47:40 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27651/#review60128
-----------------------------------------------------------

Ship it!


Great job! All of these Authenticatee reviews have been nearly flawless. Only trivial nits.


src/tests/cram_md5_authentication_tests.cpp
<https://reviews.apache.org/r/27651/#comment101464>

    Not sure why you went from 'T' to 'S' instead of 'U', but it doesn't bother me.



src/tests/cram_md5_authentication_tests.cpp
<https://reviews.apache.org/r/27651/#comment101465>

    s/credentials/credential/ (singular)



src/tests/cram_md5_authentication_tests.cpp
<https://reviews.apache.org/r/27651/#comment101466>

    s/Credentials/Credential/ (singular)


- Adam B


On Nov. 5, 2014, 4:26 p.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27651/
> -----------------------------------------------------------
> 
> (Updated Nov. 5, 2014, 4:26 p.m.)
> 
> 
> Review request for mesos, Adam B and Vinod Kone.
> 
> 
> Bugs: MESOS-2001
>     https://issues.apache.org/jira/browse/MESOS-2001
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> CRAMMD5Authentication tests now cover all default and modularized authenticator/authenticatee
combinations.
> Also adds a test for missing credentials for the authenticatee.
> 
> 
> Diffs
> -----
> 
>   src/authentication/cram_md5/authenticatee.hpp 3088a77 
>   src/tests/cram_md5_authentication_tests.cpp 74ea2ad 
>   src/tests/module.hpp 7970c28 
>   src/tests/module.cpp 482ed22 
> 
> Diff: https://reviews.apache.org/r/27651/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message