mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Hindman" <b...@berkeley.edu>
Subject Re: Review Request 27516: Rebased and re-edited patch for MESOS-1316: "Abstracted out invoking 'mesos-fetcher'".
Date Thu, 06 Nov 2014 05:00:48 GMT


> On Nov. 6, 2014, 4:44 a.m., Benjamin Hindman wrote:
> > src/tests/fetcher_tests.cpp, lines 64-67
> > <https://reviews.apache.org/r/27516/diff/3/?file=747425#file747425line64>
> >
> >     This is not your bug, but would you mind making the old tests consistent with
the tests that were added in this patch by changing the code to:
> >     
> >     CommandInfo::URI* uri = commandInfo.add_uris();
> >     uri->set_value(...);
> >     uri->set_executable(...);

Nevermind! This gets done in your next review, thanks!


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27516/#review60098
-----------------------------------------------------------


On Nov. 3, 2014, 4:36 p.m., Bernd Mathiske wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27516/
> -----------------------------------------------------------
> 
> (Updated Nov. 3, 2014, 4:36 p.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Bugs: MESOS-1316
>     https://issues.apache.org/jira/browse/MESOS-1316
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Manually rebasing and re-editing https://reviews.apache.org/r/21233/, which is supposed
to be replaced now by this patch. 
> 
> Original description: "To test the mesos-fetcher (and the setting of the environment)
more cleanly I did some refactoring into a 'fetcher' namespace."
> 
> Also moved fetcher environment tests to fetcher test file. Added two fetcher tests.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am e6a07150c10b9fa040143e394b2f913a18eeebc1 
>   src/launcher/fetcher.cpp 9323c28237010fa065ef34d74435c151ded530a8 
>   src/slave/containerizer/fetcher.hpp PRE-CREATION 
>   src/slave/containerizer/fetcher.cpp PRE-CREATION 
>   src/slave/containerizer/mesos/containerizer.cpp d4b08f54d6feb453f3a9d27ca54c867176e62102

>   src/tests/containerizer_tests.cpp 2c90d2fc18a3268c55b6dfe98699bfb36d093983 
>   src/tests/fetcher_tests.cpp d7754009a59fedb43e3422c56b3a786ce80164aa 
> 
> Diff: https://reviews.apache.org/r/27516/diff/
> 
> 
> Testing
> -------
> 
> make check on Mac OS 10.10 and Ubuntu 14.4.
> 
> In total, 3 tests fail: ExamplesTest.NoExecutorFramework, ExamplesTest.JavaFramework
> , ExamplesTest.PythonFramework. It is strongly suspected that those are unrelated to
this code change and just generally flaky.
> 
> 
> Thanks,
> 
> Bernd Mathiske
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message