mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mesos ReviewBot" <...@mesos.apache.org>
Subject Re: Review Request 27651: Updated CRAMMD5Authentication tests to additionally run against the test authenticatee module.
Date Thu, 06 Nov 2014 00:30:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27651/#review60071
-----------------------------------------------------------


Bad patch!

Reviews applied: [27619, 27493, 27494, 27495, 27651]

Failed command: ./support/apply-review.sh -n -r 27651

Error:
 2014-11-06 00:29:58 URL:https://reviews.apache.org/r/27651/diff/raw/ [10571/10571] ->
"27651.patch" [1]
error: patch failed: src/tests/module.cpp:70
error: src/tests/module.cpp: patch does not apply
Failed to apply patch

- Mesos ReviewBot


On Nov. 6, 2014, 12:26 a.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27651/
> -----------------------------------------------------------
> 
> (Updated Nov. 6, 2014, 12:26 a.m.)
> 
> 
> Review request for mesos, Adam B and Vinod Kone.
> 
> 
> Bugs: MESOS-2001
>     https://issues.apache.org/jira/browse/MESOS-2001
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> CRAMMD5Authentication tests now cover all default and modularized authenticator/authenticatee
combinations.
> Also adds a test for missing credentials for the authenticatee.
> 
> 
> Diffs
> -----
> 
>   src/authentication/cram_md5/authenticatee.hpp 3088a77 
>   src/tests/cram_md5_authentication_tests.cpp 74ea2ad 
>   src/tests/module.hpp 7970c28 
>   src/tests/module.cpp 482ed22 
> 
> Diff: https://reviews.apache.org/r/27651/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message