mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Till Toenshoff" <toensh...@me.com>
Subject Re: Review Request 27619: Updated CRAMMD5Authentication tests to additionally run against the test authenticator module.
Date Wed, 05 Nov 2014 23:56:22 GMT


> On Nov. 5, 2014, 9:06 p.m., Adam B wrote:
> > src/tests/cram_md5_authentication_tests.cpp, line 211
> > <https://reviews.apache.org/r/27619/diff/1/?file=750292#file750292line211>
> >
> >     Why was this test explicitly creating new CRAMMD5Authenticator instead of using
the default initializer with "CRAMMD5Authenticator authenticator;" like the previous tests?
> >     Doesn't seem like it did anything special with the pointer.

IIUC typed tests demand a factory method.


> On Nov. 5, 2014, 9:06 p.m., Adam B wrote:
> > src/tests/module.cpp, line 81
> > <https://reviews.apache.org/r/27619/diff/1/?file=750294#file750294line81>
> >
> >     Fix the comment: "Now add our test Authenticator module"

whoops, will update this in a jiffy.


- Till


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27619/#review60029
-----------------------------------------------------------


On Nov. 5, 2014, 3:27 p.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27619/
> -----------------------------------------------------------
> 
> (Updated Nov. 5, 2014, 3:27 p.m.)
> 
> 
> Review request for mesos, Adam B, Kapil Arya, and Vinod Kone.
> 
> 
> Bugs: MESOS-1894
>     https://issues.apache.org/jira/browse/MESOS-1894
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> see summary.
> 
> 
> Diffs
> -----
> 
>   src/authentication/cram_md5/authenticator.hpp 601248d 
>   src/tests/cram_md5_authentication_tests.cpp 74ea2ad 
>   src/tests/module.hpp 7970c28 
>   src/tests/module.cpp 482ed22 
> 
> Diff: https://reviews.apache.org/r/27619/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message