mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Cody Maloney" <c...@mesosphere.io>
Subject Review Request 27606: Standardized path handling in files
Date Wed, 05 Nov 2014 02:53:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27606/
-----------------------------------------------------------

Review request for mesos and Ben Mahler.


Bugs: mesos-1877
    https://issues.apache.org/jira/browse/mesos-1877


Repository: mesos-git


Description
-------

Files attach, detach, and browse now all call a single function to standardize the path. Before
attach, browse did the normalization. Detach did not.

Switch to strings::tokenize() for splitting apart the path into tokens, as that is more canonical
across the codebase, used by libprocess for proccessing paths.

Update detach to return a bool of whether or not the detach does anything which means that
it can be tested.

Add some additional testing to catch the inconsistencies in path handlign between attach and
detach previously, some of the oddness in current path handling so that they can be explicitly
seen when changes happen.


Diffs
-----

  src/files/files.hpp 818087b13cc787d0bd3186bb3e8a069751629bf9 
  src/files/files.cpp 12e8f75aa7bd77d2e81d5d3a7a4d09dd915854aa 
  src/tests/files_tests.cpp a696aa22d56b37ee70c6e64c81a849da6d436451 

Diff: https://reviews.apache.org/r/27606/diff/


Testing
-------

make distcheck on ubuntu 14.04


Thanks,

Cody Maloney


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message