mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jie Yu" <yujie....@gmail.com>
Subject Re: Review Request 27550: Added DiskInfo to the Resource protobuf.
Date Wed, 05 Nov 2014 02:29:25 GMT


> On Nov. 5, 2014, 12:48 a.m., Ian Downes wrote:
> > include/mesos/mesos.proto, line 393
> > <https://reviews.apache.org/r/27550/diff/1/?file=747884#file747884line393>
> >
> >     DiskInfo is a very generic name; it's not clear that it's a *persistent* disk
resource. Is there a possible need for Resource to included non-persistent disk later on and
which lead to some unfortunate naming?

That's because the name the resource is called "disk" right now. We may have CpusInfo, MemInfo
in the future.


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27550/#review59896
-----------------------------------------------------------


On Nov. 4, 2014, 12:29 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27550/
> -----------------------------------------------------------
> 
> (Updated Nov. 4, 2014, 12:29 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Vinod Kone.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 6b93e9000761857c4f335f2a8c8088e155078f54 
> 
> Diff: https://reviews.apache.org/r/27550/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message