mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinod Kone" <vinodk...@gmail.com>
Subject Re: Review Request 27552: Added a slave flag to opt out using default resources.
Date Wed, 05 Nov 2014 00:01:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27552/#review59864
-----------------------------------------------------------



src/slave/flags.hpp
<https://reviews.apache.org/r/27552/#comment101170>

    Instead of adding another flag, why not consider absence of "--resources" flag to mean
using default resources and "--resources=''" to mean using empty resources?


- Vinod Kone


On Nov. 4, 2014, 12:30 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27552/
> -----------------------------------------------------------
> 
> (Updated Nov. 4, 2014, 12:30 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Vinod Kone.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> This is used in testing of the new Resources class. See the dependent review.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/containerizer.cpp 0254679508167a390fd6fed855f19794354ac081

>   src/slave/flags.hpp 03c62a2fd040768392c7e24d93f64ca3a855c4a1 
> 
> Diff: https://reviews.apache.org/r/27552/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message