mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinod Kone" <vinodk...@gmail.com>
Subject Re: Review Request 26382: Add source and reason to TaskStatus.
Date Tue, 04 Nov 2014 19:24:32 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26382/#review59799
-----------------------------------------------------------



src/slave/slave.cpp
<https://reviews.apache.org/r/26382/#comment101104>

    kill this?



src/slave/slave.cpp
<https://reviews.apache.org/r/26382/#comment101108>

    hmm. "sendExecutorTerminatedUpdate" sounds like we are sending an update about executor
terminated (e.g., ExitedExecutorMessage) which is not correct. can you come up with a better
name? i can't think of any. alternatively don't pull this out into a function for now.


- Vinod Kone


On Nov. 4, 2014, 6:41 p.m., Dominic Hamon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26382/
> -----------------------------------------------------------
> 
> (Updated Nov. 4, 2014, 6:41 p.m.)
> 
> 
> Review request for mesos, Vinod Kone and Bill Farner.
> 
> 
> Bugs: MESOS-1830 and MESOS-343
>     https://issues.apache.org/jira/browse/MESOS-1830
>     https://issues.apache.org/jira/browse/MESOS-343
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Added source and reason, enabled TASK_ERROR, and made the changes necessary throughout
the codebase.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 397d542d93962e857d800cf0d47252b592393326 
>   src/common/protobuf_utils.hpp 212d5124b9a4cc58e61719fa7f07a61cd166e834 
>   src/common/protobuf_utils.cpp a9b65e328c4c62bff7fbf5633dda25d742d79019 
>   src/examples/balloon_framework.cpp b05d5679fe2915142907af0b2dc00c6cd76eb9c1 
>   src/examples/java/TestFramework.java bc593d0abfacb00690b1492b2b82c970f4e4de6d 
>   src/examples/low_level_scheduler_libprocess.cpp 7ef5ea78ade4ed856b97009fdfe31281f0a55c17

>   src/examples/low_level_scheduler_pthread.cpp 6e233a10117a1c7aa669806b5b430e746e227ee5

>   src/examples/no_executor_framework.cpp f98a0735b9f287e7f1bf98af6c2e9a47ca6a77b2 
>   src/examples/test_framework.cpp 187a611ebfe35cb13ee48aa5eca934cf55f34dea 
>   src/master/master.cpp d914786a2517677ee7dd4a3130b4b191ef416c26 
>   src/sched/sched.cpp d84465ca8f61a079fffbc013e3f9302be9f87487 
>   src/slave/slave.hpp 6c183f827ec2521052f8b088d4583f13e661db2c 
>   src/slave/slave.cpp b8935173bae9c124b8d08db590893334d7a45a23 
>   src/tests/fault_tolerance_tests.cpp a18a41a3e34ff112e04e693447d757403e5013bd 
>   src/tests/master_authorization_tests.cpp 652e80d0d4567b225c6ffb326725ddfde06f7fd3 
>   src/tests/master_tests.cpp 2e525749247626c05efb2f54a707599facb114b6 
>   src/tests/resource_offers_tests.cpp fe66432b1bf75ee25feb73c4bb353e4d4e5b503f 
> 
> Diff: https://reviews.apache.org/r/26382/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Dominic Hamon
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message