mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aditi Bhatnagar" <aditi24.bhatna...@gmail.com>
Subject Re: Review Request 27040: Replace hard-coded reap interval with a constant
Date Mon, 03 Nov 2014 17:32:54 GMT


> On Oct. 22, 2014, 5:26 p.m., Ben Mahler wrote:
> > There is already a constant, MESOS-1935 is to ensure that code that previously hardcoded
Seconds(1) now uses MAX_REAP_INTERVAL from reap.hpp.

Sorry, but I didn't find the constants in https://github.com/apache/mesos/blob/4693728e4f604a1cff6f01d5f2d8f0ec60eb2f96/3rdparty/libprocess/include/process/reap.hpp
.


- Aditi


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27040/#review57826
-----------------------------------------------------------


On Oct. 22, 2014, 2:45 p.m., Aditi Bhatnagar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27040/
> -----------------------------------------------------------
> 
> (Updated Oct. 22, 2014, 2:45 p.m.)
> 
> 
> Review request for mesos and Dominic Hamon.
> 
> 
> Bugs: MESOS-1935
>     https://issues.apache.org/jira/browse/MESOS-1935
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Replace the hard-coded value for the maximal and minimum reap intervals with the constants
from reap.hpp
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/reap.hpp 5e5051a 
>   3rdparty/libprocess/include/process/reap.hpp~ PRE-CREATION 
>   3rdparty/libprocess/src/reap.cpp afd956b 
>   3rdparty/libprocess/src/reap.cpp~ PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/27040/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aditi Bhatnagar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message