mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Timothy Chen" <tnac...@apache.org>
Subject Re: Review Request 26736: Ensure docker calls stop if a docker_stop_timeout is provided Added the flag docker_stop_timeout that defaults to 0, if the timeout is 0 the a docker kill will be run, otherwise a docker stop with the timeout in seconds is used. A negative value will result in a Failure.
Date Sat, 01 Nov 2014 17:25:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26736/#review59469
-----------------------------------------------------------



src/tests/docker_containerizer_tests.cpp
<https://reviews.apache.org/r/26736/#comment100752>

    This is not needed, but I'll remove it for you.



src/tests/docker_containerizer_tests.cpp
<https://reviews.apache.org/r/26736/#comment100753>

    This is not needed, but I'll remove it for you.


- Timothy Chen


On Nov. 1, 2014, 5:13 p.m., Ryan Thomas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26736/
> -----------------------------------------------------------
> 
> (Updated Nov. 1, 2014, 5:13 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-1925
>     https://issues.apache.org/jira/browse/MESOS-1925
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Ensure docker calls stop if a docker_stop_timeout is provided Added the flag docker_stop_timeout
that defaults to 0, if the timeout is 0 the a docker kill will be run, otherwise a docker
stop with the timeout in seconds is used. A negative value will result in a Failure.
> 
> 
> Diffs
> -----
> 
>   src/docker/docker.hpp 2dc692c51d6f9d45d8d7c59f8678991fd80c6e89 
>   src/docker/docker.cpp 0c0a1bfd3c1260ebdf342d0a6e0e04d7b6a111a4 
>   src/slave/containerizer/docker.cpp a6689203adbdcb0ad12583389eaeb83329e4ef6b 
>   src/slave/flags.hpp 319c002c66212ffb11759dbcc39f7661203a3e4e 
>   src/tests/docker_containerizer_tests.cpp 9d4ccc57f58d61c62aab5cdc79a129e987920bf6 
>   src/tests/docker_tests.cpp ff06a01d7f20656c05bcf5afd3bc10059dc5378d 
> 
> Diff: https://reviews.apache.org/r/26736/diff/
> 
> 
> Testing
> -------
> 
> make check
> sudo bin/mesos-tests.sh --gtest_filter="DOCKER" --verbose 
> support/mesos-style.py
> 
> 
> Thanks,
> 
> Ryan Thomas
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message