mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Timothy Chen" <tnac...@apache.org>
Subject Re: Review Request 26069: Introduce ClangFormat to Mesos.
Date Sat, 01 Nov 2014 07:41:46 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26069/#review59461
-----------------------------------------------------------

Ship it!


Ship It!

- Timothy Chen


On Oct. 5, 2014, 7:16 a.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26069/
> -----------------------------------------------------------
> 
> (Updated Oct. 5, 2014, 7:16 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Cody Maloney, Dominic Hamon, and Timothy
Chen.
> 
> 
> Bugs: MESOS-1291
>     https://issues.apache.org/jira/browse/MESOS-1291
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> We spend way too much of our time formatting, not to mention the amount of time wasted
during the review cycle to address style issues. Let’s get ClangFormat to help us!
> 
> If you don't know what ClangFormat is or how it works, take a look at the Chandler Carruth's
[live demo](http://www.youtube.com/watch?v=uvddFPavYZQ#t=23m28s) from 23m 28s to 33m 27s.
> 
> Further details and analysis are available [here](https://docs.google.com/document/d/13mC3CuG89x0-4mGUD1NK-M0mYsqvEcZ-ttx9CRmAXq8/edit?usp=sharing).
> 
> 
> Diffs
> -----
> 
>   .clang-format PRE-CREATION 
>   support/clang-format PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/26069/diff/
> 
> 
> Testing
> -------
> 
> Refer to the __Sample Diff__ section in the [Google Doc](https://docs.google.com/document/d/13mC3CuG89x0-4mGUD1NK-M0mYsqvEcZ-ttx9CRmAXq8/edit?usp=sharing)
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message